Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple expands beyond cards (ignoring border radius) #2

Closed
myfrom opened this issue Jun 21, 2019 · 1 comment · Fixed by #5
Closed

Ripple expands beyond cards (ignoring border radius) #2

myfrom opened this issue Jun 21, 2019 · 1 comment · Fixed by #5
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@myfrom
Copy link

myfrom commented Jun 21, 2019

Expected behavior:

Ripple effects get cropped to their parent element, including border radius.

Actual behavior:

Ripple effects expand beyond their parent in some cases, that is they ignore border radius of their parent

Notice how ripple on "About" card has sharp corners:

My device:

OnePlus 3T,
Android 9.0,
Lineage OS 16, build 19.06.2019

@urmilshroff
Copy link
Owner

Yes, I know about the issue. I tried working around fixing it, but the problem is that if I wrap the Material widget around ClipRRect, the tile stays permanently rounded but the splash effect goes away completely.

I'm gonna need some help on this.

@urmilshroff urmilshroff self-assigned this Jun 22, 2019
@urmilshroff urmilshroff added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 22, 2019
@ghaith96 ghaith96 mentioned this issue Aug 18, 2019
urmilshroff added a commit that referenced this issue Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants