Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Add npm version workflow #108

Closed
3 tasks
ryan-roemer opened this issue Jul 10, 2018 · 0 comments
Closed
3 tasks

Infra: Add npm version workflow #108

ryan-roemer opened this issue Jul 10, 2018 · 0 comments

Comments

@ryan-roemer
Copy link
Contributor

ryan-roemer commented Jul 10, 2018

  • preversion: run tests and lint
  • version: build
  • update docs to say all of this.

Suggested verbiage:

## Release

_(Only for project administrators)_

We use an `npm version` release workflow:

1. Run `npm version patch` (or `minor|major|ACTUAL_VERSION_NUMBER`) which runs
   tests/lint, builds all files we need to publish, mutates `package.json`,
   and does all the requisite git stuff.
2. Run `npm publish` and publish to npm if all is well.
3. Run `git push && git push --tags`

We've had failed publishes with nothing in them (see #107 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant