Types

[flexzuu]

Hey, can we publish typescript types for this package?
I saw it is written in Typescript, so this should be easy. Using it in a Typescript code base not having types is a bummer.

Maybe we can just publish the raw .ts files but am not to confident about this option.

[flexzuu]

I explored a route with using dts-gen but it is not that great maybe using tsc instead of babel for the compilation would be better but I am not sure why babel was used in the first place.

[kenwheeler]

i'm not super familiar with generating or providing types. any tips or pr?

[dyst5422]

How do you want it emitted? As commonjs, or es2015 modules?

Also, not sure what benefit you're looking for out of using babel over just tsc as you aren't using the pipeline operator anywhere that you have tagged in the babel plugins.

[dyst5422]

Basically, if you remove the "allowJs", "experimentalPipelineStage1", and "noEmit" options and specify "outDir": "./build" it will emit to ./build with types and sourcemaps when you run tsc.

[flexzuu]

I would second this

Basically, if you remove the "allowJs", "experimentalPipelineStage1", and "noEmit" options and specify "outDir": "./build" it will emit to ./build with types and sourcemaps when you run tsc.

If we come to the conclusion we want to do it with tsc I can do a pr. But I don't get the babel setup.

[dyst5422]

There are also a number of other adjustments I would make to the repo, like moving tests outside of the src directory so they don't get sucked into the distributable that's published to NPM. (You can still type check the test files by having a tsconfig that is for the IDE essentially and another one that extends it for building which excludes the tests)

[ryan-roemer]

@dyst5422 -- Tests are already ignored for publishing (modulo a small oversight with one file that I've just put up #28 to fix). Take a look at https://unpkg.com/urql/ to see what we actually publish (and lib|es/tests/utils/fetch-mock.js being there is what I've just fixed).

[ryan-roemer]

Also, for anyone discussion CJS vs. ESM, our publishing approach is both. See, e.g.:

• ESM: https://unpkg.com/urql/es/
• CJS: https://unpkg.com/urql/lib/

Hope that helps!

[kenwheeler]

I'm reluctant to publish the actual .ts source, but as far as definitions, should I be publishing to @types, or running tsc and pointing at that from package.json? cc @danielrossenwasser

[ar1a]

I can't seem to get type hinting working. I think it's because theyre hidden under a types/ subfolder and not next to the .js or in a @types package.

Would you consider moving them to @types/urql?