Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(persisted): Refactor sha256 utilities and persistedFetchExchange #3052

Merged
merged 3 commits into from
Mar 15, 2023
Merged

chore(persisted): Refactor sha256 utilities and persistedFetchExchange #3052

merged 3 commits into from
Mar 15, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 15, 2023

Summary

This is a small refactor of persistedFetchExchange to save a couple of bytes.
Nothing else has changed and this doesn't address the subscriptionExchange just yet.

Set of changes

  • Refactor sha256.ts to save on size
  • Use padLeft in sha256 utility
  • Minify body logic in persistedFetchExchange
  • Strip no-op onPush in production

@kitten kitten merged commit 8deee39 into main Mar 15, 2023
@kitten kitten deleted the chore/refactor-sha256 branch March 15, 2023 18:29
This was referenced Mar 15, 2023
Closed
Open
@github-actions github-actions bot mentioned this pull request Mar 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kitten @JoviDeCroock