chore(next): warn for missing suspense boundary #3449
Conversation
🦋 Changeset detectedLatest commit: 1106f99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| DataHydrationContextProvider, | ||
| { nonce }, | ||
| React.createElement( | ||
| React.Suspense, |
There was a problem hiding this comment.
Hm, my only concern here is that there could be legitimate uses for this. I'm imagining that some router systems may use suspense in unexpected ways, so not sure if we can somehow make detection work without a custom boundary?
There was a problem hiding this comment.
That feels counter-intuitive as for the Provider to work you would need a boundary either way so even-if something higher up is a Suspense boundary that would render the urql provider pointless
There was a problem hiding this comment.
If this Suspense is inserted on the server side, the Promise resolution in the React component will change to streaming instead of waiting.
I'm sorry, but SSR in urql without Suspense will be impossible.
https://next-blog.croud.jp/contents/7m4dShGLIpFkc0GKHIrW
Can you please adjust the server side so that Suspense is not interrupted?
Related to #3448 and #3408
Summary
We have seen a few issues where folks forget their Suspense boundary which leads to infinite requests. We will shield from infinite requests by providing our own underneath the
urqlprovider so the client doesn't get re-created and give the user a warning when we are not in production.