Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate types in simple cases and use isinstance (& protocol) based type checking #529

Merged
merged 1 commit into from Apr 4, 2023
Merged

Annotate types in simple cases and use isinstance (& protocol) based type checking #529

merged 1 commit into from Apr 4, 2023

Conversation

penguinolog
Copy link
Collaborator

  • Use super() where possible instead of direct base class

Related #525
Partial #406
Fix #510

Checklist
  • I've ensured that similar functionality has not already been implemented
  • I've ensured that similar functionality has not earlier been proposed and declined
  • I've branched off the master or python-dual-support branch
  • I've merged fresh upstream into my branch recently
  • I've ran tox successfully in local environment

Annotate types in simple cases and use isinstance (& protocol) based …
4edc7c1 
…type checking

* Use `super()` where possible instead of direct base class

Related urwid#525
Partial urwid#406
Fix urwid#510
@penguinolog penguinolog merged commit 3cfa240 into urwid:master Apr 4, 2023
5 checks passed
@penguinolog penguinolog deleted the typing branch April 4, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttrMaps can't use dict-like objects, like ChainMap, only plain dicts
1 participant
@penguinolog