Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttrMaps can't use dict-like objects, like ChainMap, only plain dicts #510

Closed
neumond opened this issue Oct 13, 2022 · 0 comments · Fixed by #529
Closed

AttrMaps can't use dict-like objects, like ChainMap, only plain dicts #510

neumond opened this issue Oct 13, 2022 · 0 comments · Fixed by #529
Assignees

Comments

@neumond
Copy link
Contributor

neumond commented Oct 13, 2022

Strict type comparison here:

if type(attr_map) != dict:

@penguinolog penguinolog self-assigned this Mar 31, 2023
penguinolog pushed a commit to penguinolog/urwid that referenced this issue Apr 4, 2023
…type checking

* Use `super()` where possible instead of direct base class

Related urwid#525
Partial urwid#406
Fix urwid#510
penguinolog added a commit that referenced this issue Apr 4, 2023
…type checking (#529)

* Use `super()` where possible instead of direct base class

Related #525
Partial #406
Fix #510

Co-authored-by: Aleksei Stepanov <alekseis@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants