Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kitchen Sink: Card Example Image should have alt text #43

Closed
davezen1 opened this issue Oct 13, 2016 · 0 comments · Fixed by #62
Closed

Kitchen Sink: Card Example Image should have alt text #43

davezen1 opened this issue Oct 13, 2016 · 0 comments · Fixed by #62
Assignees
@davezen1
Labels
1 - Ready enhancement

Comments

@davezen1
Copy link
Contributor

A descriptive alt text for image needed for Card Example.
@davezen1 davezen1 self-assigned this Nov 16, 2016
davezen1 added a commit to davezen1/cbp-theme that referenced this issue Nov 16, 2016
@davezen1
fix: a11y fix for card pictures alt text
3c148aa 
small a11y fix for alt text of card image

resolves US-CBP#43
@tma001 tma001 closed this as completed in b231a07 Nov 16, 2016
@davezen1 davezen1 mentioned this issue Nov 17, 2016
Merged
tma001 pushed a commit that referenced this issue Nov 17, 2016
@davezen1 @tma001
fix: small a11y fix for alt text of card image (#62)
bfcbb47 
* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.
tma001 pushed a commit that referenced this issue Nov 29, 2016
@davezen1 @tma001
Fix/adjust contrast (#66)
8cdfc12 
* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.

* fix: modified contrast for breadcrumbs and buttons

- Modified colors for higher contrast per a11y findings

related to #46

* fix: label contrast change

per #46 updating default label for higher contrast

* fix: fixed a11y issues for contrast and headings

- fixed heading and inline contrast style  a11y issues in kitchen sink
- fixed small class contrast to $gray in cbp theme
- fixed text muted contrast to $gray in cbp theme

Related to #46, #49

* chore: hiding indeterminate progress bar

Hiding indeterminate progress bar per a11y feedback

Relates to #48
tma001 pushed a commit that referenced this issue Dec 5, 2016
@davezen1 @tma001
File upload style override (#73)
51f7db1 
* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.

* feat: add override for file input types

overriding styles for input type files for file uploads.

relates to #72
davezen1 added a commit that referenced this issue Feb 17, 2017
@davezen1
Minor a11y changes (#78)
ab64cd9 
* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.

* fix: adjusted close [x] opacity

adjusted close x button opacity to have a higher contraster for accessibility.

* fix: updated steps and dots for a11y

- added visual contrast for dots
- added visual contrast for horizontal and vertical step indicators

see #50

* fix: updated subtle labels - success for a11y

updated the subtle label - succes to have a higher visual contrast

see #77
davezen1 added a commit that referenced this issue Apr 10, 2017
@davezen1
Add sass files to distribution (#85)
51ff1c9 
* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.

* feat: SASS directory included in the dist

Adding SASS directory to dist folder

see #81
davezen1 added a commit that referenced this issue Jul 13, 2017
@davezen1
Table th fix, placeholder with input mask fix, static labels disappea…
4866f72 
…ring, color consistency (#92)

* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.

* fix: updated plain selects underline color for consistency

updated select underline to use $gray variable like the other selects for
selectize and select2.

see #82

* fix: fix for static labels and table th tags

- Fix for table th being inconsistent with the rest of the table content
- Fix for static labels disappearing on focus

See #87 #84

* fix: updated plain selects underline color for consistency

updated select underline to use $gray variable like the other selects for
selectize and select2.

see #82

* fix: fix for static labels and table th tags

- Fix for table th being inconsistent with the rest of the table content
- Fix for static labels disappearing on focus

See #87 #84

* fix: placeholder labels not disappearing w input masks

- For inputs with placeholder labels and input masks the labels were not disappearing in active input

See #93
davezen1 added a commit that referenced this issue Jul 25, 2017
@davezen1
Fix for layout with no application header (#100)
8f81856 
* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.

* fix: adjustments for layouts where no application header is present

- added logic to check for app-header class to decider whether to make adjustments to navigation on scroll
- slight adjustment to after-header top since there is was a small gap with no app-header

* fix: adjustments for layouts where no application header is present

- added logic to check for app-header class to decider whether to make adjustments to navigation on scroll
- slight adjustment to after-header top since there is was a small gap with no app-header

* chore: fixes after merge with earlier PR

- updated generated kitchensink files per merge with refactoring of fonts and SCSS
davezen1 added a commit that referenced this issue Oct 2, 2017
@davezen1
Visual diff for testing changes (#151)
b98b467 
* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.

* feat: proof of concept for viz diff of changes

- Expected that phantomjs and pixelmatch are installed globally
- npm run viz:baseline creates a baseline.png of the CBP Kitchen Sink page
- npm run viz:new creates a new.png of local changes
- npm run viz:check creates a diff.png of diff changes

See #147

* chore: updated dev readme, minor cleanup

- removed new and diff images
- added instructions in developer guide
- updated local server url to 127.0.0.1 as 0.0.0.0 can be problematic

See #147

* chore: added gitignore and updated package-lock

See #147
davezen1 added a commit that referenced this issue Oct 6, 2017
@davezen1
Linting using StandardJS (#155)
34196f8 
* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.

* chore: added standardjs for linting

- added standardjs with auto fix and snazzy for output of lint
- cleanup and updated devdependencies
- auto and manual fix for js

See #136

* chore: removed yarn dependency

* chore: updated build script, lint of new js changes

- updated build to run lint
- linted latest js
davezen1 added a commit that referenced this issue Dec 31, 2018
@davezen1
Fix/font path issue in non minified css (#265)
329824a 
* fix: updated btn css

updated buttons css because split buttons had a gap introduced on err.

resolves #36

* fix: reverted btn font size

reverted button size to 14px

related to #36

* fix: a11y fix for card pictures alt text

small a11y fix for alt text of card image

resolves #43

* chore: added tota11y.js to kitchen sink

Added the tota11y library to the kitchen sink to make it a bit easier for all to address
a11y issues.

* chore: added standardjs for linting

- added standardjs with auto fix and snazzy for output of lint
- cleanup and updated devdependencies
- auto and manual fix for js

See #136

* chore: removed yarn dependency

* fix: removed hash for minified font paths

- minified css had a hash in the font filenames Roboto-Light_1fa8191a.woff2, removed hash config per
https://github.com/postcss/postcss-url, and now minified css behaves like non minified css and shares the correct path for fonts.

See: #241

* chore: cleanup old app directory lint updates

- removed app directory
- updated js based on lint

* chore: cleaning up old files

- removing index.js and inputmask.js as they are old files from a bygone era.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davezen1 davezen1

Labels
1 - Ready enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: small a11y fix for alt text of card image davezen1/cbp-theme
1 participant
@davezen1