Linting using StandardJS #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated buttons css because split buttons had a gap introduced on err. resolves US-CBP#36
reverted button size to 14px related to US-CBP#36
small a11y fix for alt text of card image resolves US-CBP#43
Added the tota11y library to the kitchen sink to make it a bit easier for all to address a11y issues.
- added standardjs with auto fix and snazzy for output of lint - cleanup and updated devdependencies - auto and manual fix for js See US-CBP#136
mkayan
approved these changes
Oct 2, 2017
yogeshgadge
approved these changes
Oct 3, 2017
|
@davezen1 Came across standard/standard#122 It seems .eslintrc and .eslintignore will not be honored by standard. Not sure. It seems we can do the following based on standard/standard#122 (comment)
|
- updated build to run lint - linted latest js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using StandardJS for linting because it simpler with less moving parts to worry about in terms of configuration, extra files.
https://standardjs.com/
https://standardjs.com/rules.html#javascript-standard-style
https://github.com/standard/snazzy
See #136