Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the character-limited textarea more intuitive #8

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

ConnorKrammer
Copy link

This solves the problem raised in issue #5. Namely, it:

  • Prevents input from exceeding the textarea limit when holding down a key
  • Prevents pasting text that would exceed the textarea limit
  • Updates the progress bar even when holding down a key

The solution is cross-browser, though very old browsers might not work with it.
This should also fix issue #1.

Review welcome.

@afshinm
Copy link
Contributor

afshinm commented Jul 17, 2014

That's a ton of changes @ConnorKrammer! Could you please provide an online example?

@ConnorKrammer
Copy link
Author

I just looked back on this and realized I could have done this much more simply, so I've updated it accordingly. That's cut down on the changes by a lot.

If you want to see the changes in action, open up my fork's demo page. Keep in mind that I made no changes to progress.js itself, just the demo.

Let me know if there's anything to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants