fix for multiple wideareas on a single page #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You need to remove the class "widearea-fullscreened" from the targeted textarea on closing the full screen text area in order to allow for multiple "wideareas" on a single page.
|
Great! Thanks @beastburn. Let me review it. |
|
smallTextArea.className = smallTextArea.classname.replace("widearea-fullscreened ", ""); shuld be, smallTextArea.className = smallTextArea.className.replace("widearea-fullscreened ", ""); and yes it correctly fixes the bug that multiple active WideArea instances is now allowed bug! Cheers. |
ehsandotnet
added a commit
that referenced
this pull request
May 26, 2013
Fix multiple wideareas on a single page
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You need to remove the class "widearea-fullscreened" from the targeted textarea on closing the full screen text area in order to allow for multiple "wideareas" on a single page.