-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wikidata Elastic Search - Backend Implementation #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntities and props
binh-vu
reviewed
Jun 5, 2023
…s, imporved typing by creating search models
binh-vu
reviewed
Jun 6, 2023
…nterface to return List[SearchItem], Enhanced typing covered in the PR reviews
binh-vu
approved these changes
Jun 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Wikidata search extension, that internally uses Wikidata's APIs over their cirrus search ( elastic search )
Implemented the following search routes to search for classes, entities and properties by using their names (text based search :
As the API data had html text as part of the payload data, I have used nh3 module to clean the html texts and has been added to pyproject.toml as a dependency.
For the classes search implementation, the Wikidata API returned empty strings for the class label. The local class api was leveraged to extract label and description for the class search API.
Class Search API Test :
Entity Search API Test :
Property Search API Test :