Fix encoding issues inside the input field #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach casts the received request object from a byte array to a string. Upon copying it into the UI input field, it expects again a bytes array. This back and forth conversion will try to encode binary blobs leading to malformed requests. As all functions expect to work with byte arrays the cast to a string can be removed to maintain the original requests structure
Closed
|
Damn! Sorry @mschader! I did not see this pull request and just implemented your changes (that you previously communicated to me) directly inside of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach to paste the request into the CSTC input field casts the received request object from a byte array to a string. Upon copying it into the UI input field, it expects again a bytes array. This back and forth conversion will try to encode binary blobs leading to malformed requests. As all functions expect to work with byte arrays the cast to a string can be removed to maintain the original requests structure.