Configurable TIM Signing for RSUs/SDX, Code Refactoring & UDP/Log Ingestion Updates #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update msgRepeatOptions value
Kafka version update
…t2/strip-1609dot2-header-from-unsigned-messages
Trim Nanoseconds from snmpTimestampFromIso
…ines merged. Currently only support BSM for both
Resolving merge conflicts on USDOT ODE PR
dmccoystephenson
changed the title
dmccoystephenson
changed the title
…ary in Contributing Guide
…e process documentation
…ase process documentation
dan-du-car
reviewed
Jun 12, 2024
docs/dockerhub.md
Outdated
| - zookeeper | ||
| volumes: | ||
| - ${DOCKER_SHARED_VOLUME_WINDOWS}/var/run/docker.sock:/var/run/docker.sock | ||
| KAFKA_CREATE_TOPICS: "topic.OdeBsmPojo:1:1,topic.OdeSpatTxPojo:1:1,topic.OdeSpatPojo:1:1,topic.OdeSpatJson:1:1,topic.FilteredOdeSpatJson:1:1,topic.OdeSpatRxJson:1:1,topic.OdeSpatRxPojo:1:1,topic.OdeBsmJson:1:1,topic.FilteredOdeBsmJson:1:1,topic.OdeTimJson:1:1,topic.OdeTimBroadcastJson:1:1,topic.J2735TimBroadcastJson:1:1,topic.OdeDriverAlertJson:1:1,topic.Asn1DecoderInput:1:1,topic.Asn1DecoderOutput:1:1,topic.Asn1EncoderInput:1:1,topic.Asn1EncoderOutput:1:1,topic.SDWDepositorInput:1:1,topic.OdeTIMCertExpirationTimeJson:1:1,topic.OdeRawEncodedBSMJson:1:1,topic.OdeRawEncodedSPATJson:1:1,topic.OdeRawEncodedTIMJson:1:1,topic.OdeRawEncodedMAPJson:1:1,topic.OdeMapTxPojo:1:1,topic.OdeMapJson:1:1,topic.OdeRawEncodedSSMJson:1:1,topic.OdeSsmPojo:1:1,topic.OdeSsmJson:1:1,topic.OdeRawEncodedSRMJson:1:1,topic.OdeSrmTxPojo:1:1,topic.OdeSrmJson:1:1,topic.OdeRawEncodedPSMJson:1:1,topic.OdePsmTxPojo:1:1,topic.OdePsmJson:1:1" |
There was a problem hiding this comment.
Isn't this created with kafka_init.sh script?
There was a problem hiding this comment.
Yes! This is out of date. I've updated the example docker-compose.yml file provided in the dockerhub.md file. Thank you for catching that.
| @@ -19,18 +19,9 @@ spring.http.multipart.max-request-size=1MB | |||
| #ode.uploadLocationBsm = bsm | |||
| #ode.uploadLocationMessageFrame = messageframe | |||
|
|
|||
| #USDOT Situation Data Clearinghouse (SDC)/ Situation Data Warehouse (SDW), a.k.a Data Distribution System (DDS) Properties | |||
| #USDOT Situation Data Clearinghouse (SDC)/ Situation Data Warehouse (SDW) Properties | |||
There was a problem hiding this comment.
SDX! I have updated non-code references (documentation & comments) from 'SDW' to 'SDX'
Release Process Documentation
|
Marking this as a draft for now until comments are addressed. |
…-13-2024 Addressing USDOT PR comments 6/13/2024
|
This PR is ready for re-review @dan-du-car |
dan-du-car
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
The project has undergone a number of significant updates. Overall, these changes collectively aim to improve functionality, documentation clarity, and system performance.
Changes
Dependencies Updates
Documentation Revisions
Feature Enhancements
Code Refactoring and Improvements
Related Issue
No related GitHub issue.
Motivation and Context
Updating dependencies such as Kafka and Maven plugins ensures compatibility with the latest features and security patches, while removing Zookeeper simplifies the development environment. Introducing configurable signing for RSUs and the SDX, along with a configurable default SNMP protocol, adds flexibility and improves security. Enhancements to the SNMP protocol further strengthen system reliability.
Extensive documentation revisions, including the addition of a Submodule Compatibility Guide and updated data flow diagrams, improve clarity and accuracy for developers and users. Code refactoring efforts, such as improving timestamp handling and restructuring receiver classes, streamline the codebase, enhancing readability and maintainability.
How Has This Been Tested?
Unit tests have been verified to pass with these changes. These changes have also been tested in CDOT's GCP environment.
Types of changes
Checklist:
ODE Contributing Guide