Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add medicaid project draft #947

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Add medicaid project draft #947

merged 3 commits into from
Mar 25, 2024

Conversation

amwhitty
Copy link
Contributor

No description provided.

amwhitty and others added 3 commits March 18, 2024 11:52
* Misc html header fixes

- Added two headers that were reported as missing: `<meta name="robots" ` and `<meta property="og:image:alt" `
- `<meta name="robots" content="noindex, nofollow" />` was there for non-production and if the `page.hide_from_search` was set; however, the inverse of `<meta name="robots" content="index" />` wasn't there.
- `<meta property="og:image:alt"` is a 508 string. It's dynamic depending on the image being displayed. Pages will need to include a `social_image_alt_text` or `carousel_image_alt_text` with their custom images.
- Started using`{%-` and `-%}` which removes the blank line feeds from the output. When an eng candidate might look at our source, all the blank spaces look pretty sloppy.
- Move the 5x-step if/else logic out of a single line and into separate lines at the top of the file so it is readable.
- Repeated process for other variables to be consistent.
- Split out the `application/ld+json` json into multiple lines to be more readable. It is super confusing because `{{` could be json OR Jekyll syntax. Fixed at least one bug related to this confusion.

* Add `social_image_alt_text` for all pages

* `page.content` => `content`

* Use page_description as fallback share_image_alt

* Update with Drew's alt text wording.
@amwhitty amwhitty merged commit 0ca3d5b into staging Mar 25, 2024
1 of 2 checks passed
Copy link

⚠️ Visual differences detected.
For details, click the green checkmark above.
If your PR makes intentional visual changes, update the base images by running the Visual regression testing Action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants