Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve icon settings #403

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Conversation

Wolfr
Copy link
Contributor

@Wolfr Wolfr commented Jul 15, 2021

Makes the difference between SVG icons and Icon font feature more clear to explain. This config change will need to be reflected on the website.

Currently the icon font functionality is triggered by this config setting:

  icons: {
    generateIconFont: false,
    iconFontPath: "./content/scss/_icon-font.scss",
    svgIconClassPrefix: 'o-svg-icon',
    iconFontClassPrefix: 'if'
  },

This is a mixup of different things, the svgIconClassPrefix has nothing to do with the generateIconFont and iconFontPath.

Proposal to simplify to

  /**
   *  Icon font
   *  Set up CSS class prefix
   */
  iconFont: {
    outputPath: "./content/postcss/icon-font.css",
    classPrefix: 'if'
  },
  /**
   *  SVG icons
   *  Set up CSS class
   */
  svgIcons: {
    classPrefix: 'o-svg-icon'
  },

Signed-off-by: Wolfr johan.ronsse@gmail.com

Makes the difference between SVG icons and Icon font feature more clear to explain. This config change will need to be reflected on the website.

Signed-off-by: Wolfr <johan.ronsse@gmail.com>
@vercel
Copy link

vercel bot commented Jul 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/monocompany/bedrock/DHSj87184YDMvoq15wo2C32H6p2a
✅ Preview: https://bedrock-git-enhancement-improve-icon-settings-monocompany.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant