Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table details not collapsable in material theme #306

Closed
dstadelm opened this issue Jun 25, 2021 · 6 comments · Fixed by #376
Closed

Table details not collapsable in material theme #306

dstadelm opened this issue Jun 25, 2021 · 6 comments · Fixed by #376

Comments

@dstadelm
Copy link

Using the material theme (and others) the details of requirements et al. are static and the arrow items are displayed incorrectly. Is there a possibility to work around this issue?
image

@danwos
Copy link
Member

danwos commented Jun 25, 2021

It looks like no sphinx-needs js code gets executed.
Are you using the latest versions?

@dstadelm
Copy link
Author

Boah, your fast :-)

sphinx-4.0.0
sphinxcontrib-needs-0.6.3

@dstadelm
Copy link
Author

And it works with rtd theme, and also alabaster, but not with material

@danwos
Copy link
Member

danwos commented Jun 25, 2021

Thanks for the details.
Will need some time to check how material is handling js and co. and how a fix/workaround may look like.

@twodrops
Copy link
Collaborator

I remember having the same issue for alabaster and RTD sometime ago #242

@danwos
Copy link
Member

danwos commented Sep 23, 2021

Sphinx-Material is deleting ALL css table classes by default.
So the css and js code from Sphinx-Needs can not find the needed tables in the html document anymore.

I created a PR for Sphinx-Material to be able to deactivate this handling for specific tables:
bashtage/sphinx-material#120

With #376 Sphinx-Needs sets a specific class, so that Sphinx-Material does not care about Sphinx-Needs tables.
However, this will only work, if the PR for Sphinx-Material gets merged too.

danwos added a commit that referenced this issue Sep 23, 2021
danwos added a commit that referenced this issue Sep 23, 2021
danwos added a commit that referenced this issue Sep 23, 2021
danwos added a commit that referenced this issue Sep 23, 2021
To-Do Priorities automation moved this from Prio 3 to Done Sep 23, 2021
danwos added a commit that referenced this issue Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

3 participants