-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variants for need options #671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small findings in the docs.
We should also add already the Sphinx-Tags support.
Then the feature is already complete and users can go on bug hunt.
97a7a2b
to
8755f7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work.
This PR implements variant handling based on need options.
Usecase 1
In
conf.py
:In any
.rst
file:From the above example, there are pre-defined variants, which have a “filter string” that defines to which variant a need belongs in the current situations.
Usecase 2 - Filter in option
There shall also be a way to use the filter string inside the options
Default option
The last option can exist without a filter, so we consider it if no other options fulfil their filter rules.