New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃攢馃敡 MERGE: Add strict typing for most sphinx_needs
modules
#1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisjsewell
changed the title
馃敡 Add strict typing for
馃敡 Add strict typing for more Aug 28, 2023
sphinx_needs.diagrams_common
sphinx_needs
modules
Will be fixed by #1003 |
danwos
approved these changes
Aug 28, 2023
chrisjsewell
force-pushed
the
typing-2
branch
3 times, most recently
from
August 28, 2023 13:26
de0767a
to
e369be1
Compare
chrisjsewell
force-pushed
the
typing-2
branch
2 times, most recently
from
August 28, 2023 22:48
e1ce09d
to
b1dfc11
Compare
chrisjsewell
changed the title
馃敡 Add strict typing for more
馃敡 Add strict typing for most Aug 29, 2023
sphinx_needs
modulessphinx_needs
modules
chrisjsewell
changed the title
馃敡 Add strict typing for most
馃攢馃敡 MERGE: Add strict typing for most Aug 29, 2023
sphinx_needs
modulessphinx_needs
modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds strict typing to most of the package, building on #987 and #998 to try to confine use of dynamic types to a small surface area.
This hopefully makes it easier for developers to navigate the code base, and lessens the potential for bugs arising from type mismatches.
There are still some open questions, particularly around
NeedsInfoType
, whichprocess_need_nodes
)