Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃憣 From string fix #1031

Merged
merged 2 commits into from
Sep 22, 2023
Merged

馃憣 From string fix #1031

merged 2 commits into from
Sep 22, 2023

Conversation

danwos
Copy link
Member

@danwos danwos commented Sep 19, 2023

No description provided.

@danwos danwos changed the title From string fix 馃憣 From string fix Sep 20, 2023
chrisjsewell
chrisjsewell requested changes Sep 20, 2023
View reviewed changes
sphinx_needs/external_needs.py Outdated Show resolved Hide resolved
chrisjsewell
chrisjsewell approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good cheers

@danwos danwos merged commit 0954a50 into master Sep 22, 2023
12 checks passed
@danwos danwos deleted the from_string_fix branch September 22, 2023 04:30
nhatnamnguyengtvthcm pushed a commit to nhatnamnguyengtvthcm/sphinx-needs that referenced this pull request Sep 25, 2023
@danwos @nhatnamnguyengtvthcm
馃憣 From string fix (useblocks#1031)
789d7e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisjsewell chrisjsewell chrisjsewell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danwos @chrisjsewell