Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of reST syntax in prefix parameter of meta #1046

Merged
merged 3 commits into from Oct 20, 2023

Conversation

sleiner
Copy link
Contributor

@sleiner sleiner commented Oct 13, 2023

The usage of the prefix parameter of the meta layout function (as per the docs) does not work. There are two problems with this:

  1. The documentation for meta does not mention that backslashes need to be escaped and shows unescaped backslashes instead. The docs for meta_all do not make this mistake.
  2. Since version 0.16, docutils inserts null-characters when parsing escaped backslashes, which in turn is not accepted by ast.parse. The solution is described in the release notes for docutils 0.16: Using node.astext() instead of str(node)

@danwos
Copy link
Member

danwos commented Oct 19, 2023

Thanks for the PR and the updated docs 👍

If you like, you can also add yourself to the AUTHORS list.
I will merge this PR tomorrow, so hurry up ;) (Or create a second PR for the AUTHORS update later)

@danwos danwos merged commit 38c2870 into useblocks:master Oct 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants