Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Replace black/isort/pyupgrade/flake8 with ruff #1080

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Dec 1, 2023

I would say ruff is becoming the standard now, for linting and formatting, and it simplifies things a bit.

Note a lot of the changes come from the fact that I've gone from the currently (specifically) configured 120 max line length, to the the black/ruff default of 88.
I'm open to increasing this, but personally feel its best to juct stick to the default.

@chrisjsewell chrisjsewell changed the title 🔧 Replace black/isort/pyupgrade with ruff 🔧 Replace black/isort/pyupgrade/flake8 with ruff Dec 1, 2023
@ubmarco
Copy link
Member

ubmarco commented Dec 1, 2023

Thanks for the efforts, that simplifies our life

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (8e2fcd6) 83.93% compared to head (f5fd112) 83.93%.

Files Patch % Lines
sphinx_needs/directives/needfilter.py 15.38% 11 Missing ⚠️
sphinx_needs/services/github.py 43.75% 9 Missing ⚠️
sphinx_needs/directives/needbar.py 50.00% 8 Missing ⚠️
sphinx_needs/directives/needgantt.py 62.50% 6 Missing ⚠️
sphinx_needs/directives/needuml.py 75.00% 6 Missing ⚠️
sphinx_needs/diagrams_common.py 44.44% 5 Missing ⚠️
sphinx_needs/functions/functions.py 78.26% 5 Missing ⚠️
sphinx_needs/api/need.py 66.66% 4 Missing ⚠️
sphinx_needs/directives/list2need.py 60.00% 4 Missing ⚠️
sphinx_needs/functions/common.py 33.33% 4 Missing ⚠️
... and 20 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1080   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files          56       56           
  Lines        6461     6462    +1     
=======================================
+ Hits         5423     5424    +1     
  Misses       1038     1038           
Flag Coverage Δ
pytests 83.93% <79.06%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell reopened this Feb 15, 2024
@chrisjsewell chrisjsewell merged commit 84a5f72 into master Feb 15, 2024
33 checks passed
@chrisjsewell chrisjsewell deleted the ruff-fmt branch February 15, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants