🐛 FIX: Centralise splitting of need ID

[chrisjsewell]

Ensure the splitting of a need ID, on a . into main.part IDs, cannot except (and remove duplication of the logic)

closes #1096

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73b961e) 83.19% compared to head (5c36939) 83.17%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
- Coverage   83.19%   83.17%   -0.03%     
==========================================
  Files          56       56              
  Lines        6456     6447       -9     
==========================================
- Hits         5371     5362       -9     
  Misses       1085     1085              

Flag	Coverage Δ
pytests	83.17% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[chrisjsewell]

Note @twodrops this will not warn if you have an ID that incorrectly has a .; it will split them into main.part, as expected.

If you wanted to warn or allow . in main IDs, we would need something a little more complex, like a configuration option to "turn-off" allowing need part IDs