Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Enforce type checking in api/need.py #1117

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 19, 2024

Note, I have made changes in a way to not breaking any existing logic / tests.
However, I've added a number of TODOs where I have "ignored" type incompatibilities that do look like they should be resolved.

For example, add_external_need, understandably sets docname/lineno to None, however, some parts of the code base appear to not account for this possibility.

Anyway, I'll look into these in later PRs

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aef3a0f) 85.82% compared to head (b2d6c85) 85.82%.

Files Patch % Lines
sphinx_needs/api/need.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
- Coverage   85.82%   85.82%   -0.01%     
==========================================
  Files          56       56              
  Lines        6506     6503       -3     
==========================================
- Hits         5584     5581       -3     
  Misses        922      922              
Flag Coverage Δ
pytests 85.82% <97.43%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit 99cb3e4 into master Feb 20, 2024
19 checks passed
@chrisjsewell chrisjsewell deleted the typing-needs-api branch February 20, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants