🔧 Remove constraints from extra_options
#1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1123 +/- ##
=======================================
Coverage 85.83% 85.83%
=======================================
Files 56 56
Lines 6507 6508 +1
=======================================
+ Hits 5585 5586 +1
Misses 922 922
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danwos
approved these changes
Feb 22, 2024
`constraints` is a core sphinx-need option, and so it is not necessary to add it to the `extra_options` (this change was made as a result of #1122)
chrisjsewell
force-pushed
the
remove-constraints-default
branch
from
c151f6e
to
a10a115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constraintsis a core sphinx-need option, and so it is not necessary to add it to theextra_options(this change was made as a result of #1122)