Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Remove hidden field from extra_options #1124

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 21, 2024

I have a suspicion this was added due to a misunderstanding:

When a user creates a need like:

.. req:: Requirement A
   :hide:

It is stored on the need docutils node as node_need["hidden"] = True, BUT on the need data item as need["hide"] = True.
Indeed, as you can see in the changes, its value is never anything except ""

closes #1014

(related to #1122)

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e142d24) 85.83% compared to head (262e44b) 85.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
- Coverage   85.83%   85.83%   -0.01%     
==========================================
  Files          56       56              
  Lines        6508     6507       -1     
==========================================
- Hits         5586     5585       -1     
  Misses        922      922              
Flag Coverage Δ
pytests 85.83% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit 98777ea into master Feb 22, 2024
18 of 19 checks passed
@chrisjsewell chrisjsewell deleted the remove-hidden-extra branch February 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "hidden" need data field?
2 participants