Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Remove hard-coding of completion and duration need fields #1127

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

chrisjsewell
Copy link
Member

As discussed in #1122 (comment),
These fields are used by needgantt but their name can be configured by needs_duration_option and needs_completion_option.

So here we remove the hard-coding and dynamically use these configuration options to set what option/key names are added.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (3719cbd) to head (d7d82a0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
- Coverage   85.81%   85.81%   -0.01%     
==========================================
  Files          56       56              
  Lines        6508     6505       -3     
==========================================
- Hits         5585     5582       -3     
  Misses        923      923              
Flag Coverage Δ
pytests 85.81% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit eb81f2e into master Feb 23, 2024
18 checks passed
@chrisjsewell chrisjsewell deleted the duration_completion_extras branch February 23, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants