Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敡 Replace Directive with SphinxDirective #986

Merged
merged 1 commit into from Aug 25, 2023
Merged

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Aug 25, 2023

SphinxDirective provides a number of additional helper methods over the docutils class, including access to the Sphinx environment.
This PR ensures it is used for all directives

`SphinxDirective` provides a number of additional helper methods, including access to the Sphinx environment
Copy link
Member

@danwos danwos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh nice, that makes it simpler.
Thanks for the PR . Approved 馃憤

@chrisjsewell chrisjsewell merged commit 4479bee into master Aug 25, 2023
10 checks passed
@chrisjsewell chrisjsewell deleted the sphinx-directive branch August 25, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants