Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fix execute_func #994

Merged
merged 1 commit into from Aug 28, 2023
Merged

馃悰 Fix execute_func #994

merged 1 commit into from Aug 28, 2023

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Aug 26, 2023 •
edited

Needs functions were being parsed the sphinx env, as opposed to the required sphinx app, as the first argument.

Note, this is good example of where better type annotating and checking would be very beneficial 馃槄

@chrisjsewell
馃悰 Fix execute_func
c3aa01d 
Needs functions were being parsed the sphinx `env`, as opposed to the required sphinx `app`, as the first argument.

Note, this is good example of where better type annotating and checking would be beneficial
@chrisjsewell chrisjsewell merged commit 87d326e into master Aug 28, 2023
10 checks passed
@chrisjsewell chrisjsewell deleted the fix-execute-func branch August 28, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwos danwos danwos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrisjsewell @danwos