-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: unable to set request bodies with colon characters in their names #571
Comments
The issue is not the colon, but rather the newline. I'll investigate on how newlines can be used in the request. |
The issue was that the imported (and also any manually written) parameter values have not been encoded thus resulting in invalid bruno files. Fix is created. With the fix, everything should work after you reimport the collection. |
fix #571 - allow newlines and encode uri form data
Thanks for the fix @SoulKa ! With version 0.27.2 I can manually adjust the fields after the import so that the property is named You can look at home Create comment (John Doe) is imported, for instance. |
Awesome, thanks @SoulKa ! |
@SoulKa I had to revert the fix as this was causing #1339 and #1076 Commit: a904672 This fix is going in the So how do we solve this issueBefore we approach a solution, I think we should never auto encode / decode values. It should always be configurable (See #732) I see 2 Solutions Toggle Inside Request SettingsI am thinking of supporting a new tab inside the request pane called Settings. This should have a toggle that allows to choose to encode Form URL Params before saving the request. Bru LangThere is a standardization effort ongoing for Bru Lang. The new lang structure will support multiline strings and this issue would go away. ETA for support for migrating to new structure is likely early-march 2024 |
I think adjusting the Bru Lang is the correct way to go in the long term. I haven't checked all the Bruno updates since then. |
@helloanoop I believe we can close the PR #804 (fix for #802) then? The issue will be resolved when the Bru Lang supports multiline strings right? |
@helloanoop - I was looking around the issue tracker and discussions and could not find a place to watch for
Is that already available somewhere? Thanks! |
For folks looking for a work-around, use a variable for key names that contain colons, e.g. {{resourceTypeKey}} then define the value as "sling:resourceType" in the collection, environment, or request (wherever is most appropriate). |
I can't seem to find a way to use the variable in the Key column, it doesn't seem to resolve it compared to using it in the Value column. |
Hi,
I work on applications that make heavy use of namespacing property names with colons, e.g. sling:propertyType. I imported one collection for such an app from Insomnia and noticed that the parameters are displayed incorrectly in the UI.
The data is stored in the file as
Naively trying to escape the colon values did not work, both
and
look for the first
:
character to identify the field name.Is there a way to have field names include the colon character?
The text was updated successfully, but these errors were encountered: