Global and Collection preferences Proxy Settings validation bug: empty port rejected even when proxy disabled

[bhaugeea]

You cannot save the app preferences with empty proxy settings because "" will get turned into NaN. It looks like maybe the Yup daisychain just needs to be reordered, but in any case an empty value should be accepted.

bruno/packages/bruno-app/src/components/Preferences/ProxySettings/index.js

Line 24 in ba76109

port: Yup.number()

If you find this issue looking for a workaround, just throw an arbitrary number in that field and you can proceed.

[mirkogolze]

Do you want to say that the port should not be mandatory if the proxy is enabled?
This means that you have an proxy server which uses e.G. port 80 for http protocol or 443 for https?

[martinsefcik]

@mirkogolze @helloanoop
I think this issue was fixed by PR #951 and should be closed

[sanjai0py]

Closing this issue as the PR fixing the issue had already been merged and released in v1.2.0