-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): CAN-340 Show step name on error #1097
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6a833ee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
3a9f017
to
d85093f
Compare
7735999
to
6a833ee
Compare
Yea, I think the improvement is surfaced if e.g. it throws an error parsing a template string? (Like see what follows the log output when it's in the new position from this pr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem with this implementation is that it prints out the step name every single time, even if its not actually being executed
in order to determine whether a step should be executed or not, its configuration needs to be computed, which requires doing some things which may result in error.
I think the only approach we have to this is adding a fake log message for this if an error is generated and only in that case.
Needs more testing/verification