Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): misc #1128

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix(builder): misc #1128

merged 2 commits into from
Jun 25, 2024

Conversation

dbeal-eth
Copy link
Contributor

quite a few misc fixes in here:

  • add timestamp and block number info to more places
  • fix(builder): all artifacts for trace
  • fix access recorder not properly resolving with steps that have logic
  • better stack tracing
  • better printing out of step name prior to printing out errors

@dbeal-eth dbeal-eth self-assigned this Jun 17, 2024
Copy link

changeset-bot bot commented Jun 17, 2024

⚠️ No Changeset found

Latest commit: d85093f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Jun 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d85093f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@noahlitvin
Copy link
Contributor

Just rebased to this branch here: #1097

sometimes the cannon trace was missing all of the artifact builds
@dbeal-eth dbeal-eth force-pushed the fix-all-artifacts-for-trace branch from 3a9f017 to d85093f Compare June 25, 2024 05:34
@dbeal-eth dbeal-eth merged commit 40bd537 into main Jun 25, 2024
8 of 9 checks passed
@dbeal-eth dbeal-eth deleted the fix-all-artifacts-for-trace branch June 25, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants