Reduce page size #60
Merged
Reduce page size #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
reviewed
Mar 23, 2020
| @@ -9,8 +9,7 @@ in multiple plots, comic alignments | |||
| var RNAInteractionViewer = (function(riv) { | |||
| riv.configObject = null; | |||
| riv.model = null; | |||
| riv.showRecords = 50; | |||
| riv.nIncrement = 50; | |||
| riv.nIncrement = 25; | |||
There was a problem hiding this comment.
riv.showRecords should really be removed?
There was a problem hiding this comment.
Yes, it's not being used.
|
@bgruening thank you |
|
I still need to rebuild the client and so on ... @anuprulez can you please talk to Oleg, he knows how to create webpack based Vis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of records from 50 to 25 shown per page (for more records, Galaxy is responding with 502 error)
Only one copy of https://github.com/usegalaxy-eu/galaxy/tree/release_19.09_europe/config/plugins/visualizations/chiraviz folder should be copied to https://github.com/usegalaxy-eu/galaxy/tree/release_19.09_europe/static/plugins/visualizations
But, I see them copied twice. It should have only one copy viz's the static folder like other visualisations.
ping @bgruening