Bundle chira

[OlegZharkov]

Introduce webpack to Chira Visualization, remove all dependencies from git repo (jquery, underscore, bootstrap, etc...)
It would be nice, if someone familiar with this visualization will try it locally before the actual merge. You don't need to rebuild the while client, yarn run gulp plugins will work

[bgruening]

@anuprulez @pavanvidem can you please test? If this is in place we could upstream the changes with the datatypes

[anuprulez]

I tested it and found the following issues:

• If there is an alignment present, it shows an error:

An example on the EU server

I think visualize-alignment.js file is not bundled

• The left and right margin are too big (the margins between viz and history and tool panels).

An example on the EU server

• it does not take the full screen

An example on the EU server

• The dropdowns are not taking the maximum width of their items

An example on the EU server

Thanks a lot for working on this @OlegZharkov
Would you like to have a look at it? @pavanvidem
(if yes, then please follow these steps;

1. Install gulp
2. Execute yarn run gulp plugins at $galaxy/client )

ping @bgruening

[OlegZharkov]

Oh, I see. How do I actually see an alignment? I pressed a few buttons and it always showed that alignment is not there. But anyway, I'm pretty sure why visualize-alignment.js isn't there, I'll fix it. As for margin, I have an idea, I'll try it tomorrow.

Thanks, a lot @anuprulez for the feedback. Visualize would be there very very soon... for margin I will need to investigate a bit. From Screenshots it looks like a problem with font-awesome. I'll just change a few things... Thanks!

[bgruening]

@anuprulez;

(if yes, then please follow these steps;

I think, hope, make client-production should work. So that we can deploy this easily. Could you test this with make client-production as well?

[OlegZharkov]

@bgruening make client-production must definitely work, that why this line is there . yarn run gulp plugins is only the case, if you don't want to rebuild the whole client. Even single run.sh should do the job actually (compile visualization and copy bundled stuff to static dir).

@anuprulez you don't need to install gulp globally. Just go to galaxy/client and yarn install && yarn run gulp plugins. I want to check the use case with alignment. How do I see one?

[anuprulez]

@OlegZharkov Please follow these steps:

1. On the first page, please click on any bar to go to the next page
2. On the second page, please choose Hybrid from --filter-- dropdown, <> from --operator-- and write NA in the Enter value textbox
3. Press enter

You will see only those interactions on the left with alignment information. Please click on +
icon and select a row. You will find the alignment.

Example:

[OlegZharkov]

@anuprulez Thanks a lot! That was very very useful! Should work now. Margin is still in the process of debugging...

[anuprulez]

@OlegZharkov I tested it again. Looks ok to me 👍

[OlegZharkov]

@anuprulez Thanks a lot for testing!The problem was css loading race. Well, since it works now... @bgruening should I create another PR on upstream repo?

[bgruening]

@bgruening should I create another PR on upstream repo?

this is a question for @anuprulez ... I think this and the datatype should go upstream. Hopefully, this will be accepted. If Anup does not care about the commit history and the credits you are welcome to do the PR. But maybe Anup wants to do it.

[pavanvidem]

thanks a lot all for your efforts!

[OlegZharkov]

@bgruening should I create another PR on upstream repo?

this is a question for @anuprulez ... I think this and the datatype should go upstream. Hopefully, this will be accepted. If Anup does not care about the commit history and the credits you are welcome to do the PR. But maybe Anup wants to do it.

Commit history is preserved with cherry pick, isn't it? But I don't really mind, @anuprulez you're always welcome to rebase it ;)

[anuprulez]

@OlegZharkov if you like, please create a PR on Galaxy main. The review comments we can share if you like or I can take them. Thanks a lot for working on it.