Skip to content

Commit

Permalink
fix(core): need to await init
Browse files Browse the repository at this point in the history
  • Loading branch information
reel committed Apr 4, 2018
1 parent 2eb0a25 commit 88203e6
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
6 changes: 4 additions & 2 deletions packages/core/src/2.server.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ class Server extends BaseModule {
// const ws = new Websocket(this.httpServer);
// ws.init();

this.port = henri.config.has('port') ? henri.config.get('port') : 3000;
this.port = this.henri.config.has('port')
? this.henri.config.get('port')
: 3000;

app.use(timings);

Expand Down Expand Up @@ -207,7 +209,7 @@ class Server extends BaseModule {
port = henri.isDev ? await choosePort('0.0.0.0', port) : port;
return httpServer
.listen(port, function() {
henri.pen.info('server', 'listenning');
henri.pen.info('server', 'ready for battle');
const urls = prepareUrls('http', '0.0.0.0', port);
henri.isDev && watch();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

exports[`henri general should match snapshot 1`] = `
Henri {
"_middlewares": Array [],
"cwd": [Function],
"env": "test",
"isDev": false,
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/__tests__/controllers.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ const BaseModule = require('../base/module');
const Henri = require('../henri');

describe('controllers', () => {
beforeEach(() => {
beforeEach(async () => {
this.henri = new Henri({ runlevel: 2 });
this.henri.init();
await this.henri.init();
});

test('should be defined', () => {
Expand Down
7 changes: 3 additions & 4 deletions packages/core/src/__tests__/models.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@ const BaseModule = require('../base/module');
const Henri = require('../henri');

describe('models', () => {
beforeAll(() => {
this.henri = new Henri({ runlevel: 5 });
this.henri.init();
beforeAll(async () => {
this.henri = new Henri({ runlevel: 2 });
await this.henri.init();
});

test('should be defined', () => {
console.log(this.henri);
expect(this.henri.model).toBeDefined();
});

Expand Down

0 comments on commit 88203e6

Please sign in to comment.