Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(disk): use local mongdb instead of disk #87

Merged
merged 4 commits into from Nov 13, 2019

Conversation

reel
Copy link
Member

@reel reel commented Nov 13, 2019

The sails-disk integration was causing problems in testing.
The temporary files were not well cleaned and there was often random dead-locks.
This mongodb package fetches the mongodb binary and we run it:

  • In a temp directory in dev (for persistance)
  • In memory for testing
  • There should not be more than 4 concurrent Jest process
  • The best option is using --runInBand in testing

The sails-disk integration was causing problems in testing.
The temporary files were not well cleaned and there was often random dead-locks.
This mongodb package fetches the mongodb binary and we run it:
- In a temp directory in dev (for persistance)
- In memory for testing
- There should not be more than 4 concurrent Jest process
- The best option is using --runInBand in testing
@reel reel merged commit 7ee22c0 into master Nov 13, 2019
@reel reel deleted the reel/use-mongo-memory-server branch November 13, 2019 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant