Elasticsearch URL & Host Mess #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically both `ELASTICSEARCH_HOST` and `ELASTICSEARCH_URL` should use full URLs (with schemes and ports) or the connection might not work
|
Merged into #318 with the release that removes ELASTICSEARCH_HOST from lagoon-core. Note that logs-concentrator still uses ELASTICSEARCH_HOST in this chart (and presumably other ones upstream) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our values for elasticsearch is a mess, we have multiple ways to define the same thing.
This change now just uses
elasticsearchURLlike we already havekibanaURLand otherxxxURLTurns out that all services in lagoon core can handle full URLs with Scheme and Ports (like they should), so it's probably the best to do it this way.
As soon as uselagoon/lagoon#2786 is merged we can also remove
ELASTICSEARCH_HOSTbut until then I would leave it in for BC