Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check deploy message responses for string errors #190

Closed
wants to merge 1 commit into from
Closed

Check deploy message responses for string errors #190

wants to merge 1 commit into from

Conversation

shreddedbacon
Copy link
Member

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The Lagoon API sends a string result even for some errors when triggering deployments using any of the deployX mutations. This PR adds a check to check for Error: in the response and makes the CLI use an actual error exit code instead of 0.

Changelog Entry

Closing issues

closes #189

@shreddedbacon
Copy link
Member Author

Not needed once uselagoon/lagoon#3568 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[deploy branch command] Exit code returns 0, should return > 0 for errors
1 participant
@shreddedbacon