Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw an error on deployment errors triggered via the api #3568

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

shreddedbacon
Copy link
Member

@shreddedbacon shreddedbacon commented Oct 15, 2023

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Database Migrations

  • If your PR contains a database migation, it MUST be the latest in date order alphabetically

Closing issues

@shreddedbacon
Copy link
Member Author

This is just a place holder, probably not to be merged because unsure how far this possibly breaks

@tobybellwood
Copy link
Member

As odd as the logic may seem, we should flag this as a deprecation to change in a future release.

"We will be deprecating the returning of these as error strings, in favour of returning an actual error"

@tobybellwood tobybellwood added this to the 2.20.0 milestone May 30, 2024
@tobybellwood tobybellwood marked this pull request as ready for review June 13, 2024 22:49
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to move forwards with these. Will post a clear message in the release notes that errors are now actually errors. Will go through all internal tools to ensure they work as expected

@tobybellwood tobybellwood merged commit 02d817c into main Jun 19, 2024
1 check passed
@tobybellwood tobybellwood deleted the deploy-actual-error branch June 19, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants