Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Include update environment functionality #281

Merged
merged 11 commits into from
Jul 14, 2023
Merged

Feature: Include update environment functionality #281

merged 11 commits into from
Jul 14, 2023

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Jul 3, 2023 •
edited

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Adds the functionality to the CLI to allow environment update commands to be run.

closes #236

@CGoodwin90 CGoodwin90 marked this pull request as ready for review July 5, 2023 23:27
@shreddedbacon
Copy link
Member

Is this ready for review, or still WIP? If it is ready, can you update the PR title please :)

@CGoodwin90 CGoodwin90 changed the title WIP: Include update environment functionality Feature: Include update environment functionality Jul 10, 2023
shreddedbacon
shreddedbacon requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to address around auto-idle flag

cmd/environment.go Outdated Show resolved Hide resolved
cmd/environment.go Outdated Show resolved Hide resolved
cmd/environment.go Show resolved Hide resolved
shreddedbacon
shreddedbacon approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@shreddedbacon shreddedbacon merged commit c712b57 into main Jul 14, 2023
4 checks passed
@shreddedbacon shreddedbacon deleted the update-environment branch July 14, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow environments to be updated
2 participants
@CGoodwin90 @shreddedbacon