Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Updated various commands to utilize machinery #300

Merged
merged 7 commits into from
Dec 4, 2023
Merged

Fix: Updated various commands to utilize machinery #300

merged 7 commits into from
Dec 4, 2023

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Oct 30, 2023 •
edited
Loading

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Various commands are currently returning Error: graphql: Syntax Error: Unexpected <EOF> due to using a legacy lagoon client. Resolved utilizing machinery client & updated package to v0.0.12

  • listProjectByMetadata
  • updateProjectMetadata
  • deleteProjectMetadataByKey
  • addDeployTargetConfigCmd
  • getTaskByID
  • runActiveStandbySwitch

@CGoodwin90 CGoodwin90 changed the title Fix: Updated listProjectByMetadata to utilize machinery Fix: Updated various commands to utilize machinery Oct 30, 2023
@CGoodwin90 CGoodwin90 marked this pull request as ready for review October 31, 2023 01:27
@shreddedbacon
Copy link
Member

You should also remove the functions from the CLI internal packages if they're not used by anything else for anything that was replaced with machinery

shreddedbacon
shreddedbacon approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreddedbacon shreddedbacon merged commit f1a8c0d into main Dec 4, 2023
4 checks passed
@shreddedbacon shreddedbacon deleted the fix_projectsByMetadata branch December 4, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CGoodwin90 @shreddedbacon