Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Updates return types to utilize the output package #301

Merged
merged 8 commits into from
Mar 21, 2024

Conversation

CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Nov 10, 2023

Updates various commands to return zero results + relevant messaging, instead of returning an error when no results are found for a valid command.

Requires uselagoon/machinery#43

Closes #318

@shreddedbacon
Copy link
Member

Is this one still required?

@CGoodwin90
Copy link
Contributor Author

Just disregard this one for now, need to go through and see if it's worth implementing

@shreddedbacon shreddedbacon added the revisit Issue needs to be revisited label Dec 5, 2023
@CGoodwin90 CGoodwin90 marked this pull request as ready for review February 27, 2024 04:11
@CGoodwin90 CGoodwin90 removed the revisit Issue needs to be revisited label Feb 28, 2024
@shreddedbacon shreddedbacon self-requested a review March 21, 2024 21:13
@shreddedbacon
Copy link
Member

@CGoodwin90 can you fix this one up so it can be reviewed for merging today please :D

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now

@shreddedbacon shreddedbacon merged commit 936d760 into main Mar 21, 2024
4 checks passed
@shreddedbacon shreddedbacon deleted the updating_return_types branch March 21, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Valid command producing an error shows usage string unnecessarily when using "list environments"
2 participants