Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Includes logic checks if project doesn't exist or no notifications found (#322) #323

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Improvement: Includes logic checks if project doesn't exist or no notifications found (#322) #323

merged 4 commits into from
Mar 20, 2024

Conversation

CGoodwin90
Copy link
Contributor

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Updates the existing project notifcation commands to utilize machinery, checks if a project is returned and whether notifications are found.

Requires uselagoon/machinery#45

closes #322

@CGoodwin90 CGoodwin90 mentioned this pull request Mar 13, 2024
Merged
@CGoodwin90 CGoodwin90 marked this pull request as ready for review March 13, 2024 03:53
@shreddedbacon shreddedbacon enabled auto-merge (squash) March 20, 2024 01:35
@shreddedbacon shreddedbacon merged commit 9bb1ee7 into main Mar 20, 2024
4 checks passed
@shreddedbacon shreddedbacon deleted the list-notifications-fix branch March 20, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when listing notifications if project doesn't exist
2 participants
@CGoodwin90 @shreddedbacon