fix: throw an error on deployment errors triggered via the api

uselagoon · Oct 16, 2023 · bddde3f · bddde3f
1 parent 083aa40
commit bddde3f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/services/api/src/resources/deployment/resolvers.ts b/services/api/src/resources/deployment/resolvers.ts
@@ -741,7 +741,7 @@ export const deployEnvironmentLatest: ResolverFn = async (
       break;
 
     default:
-      return `Error: Unknown deploy type ${environment.deployType}`;
+      throw new Error(`Error: Unknown deploy type ${environment.deployType}`);
   }
 
   userActivityLogger(`User triggered a deployment on '${deployData.projectName}' for '${environment.name}'`, {
@@ -790,7 +790,7 @@ export const deployEnvironmentLatest: ResolverFn = async (
           meta,
           `*[${deployData.projectName}]* Error deploying \`${environment.name}\`: ${error.message}`
         );
-        return `Error: ${error.message}`;
+        throw new Error(error.message);
     }
   }
 };
@@ -889,7 +889,7 @@ export const deployEnvironmentBranch: ResolverFn = async (
           meta,
           `*[${deployData.projectName}]* Error deploying \`${deployData.branchName}\`: ${error}`
         );
-        return `Error: ${error}`;
+        throw new Error(error.message);
     }
   }
 };
@@ -999,7 +999,7 @@ export const deployEnvironmentPullrequest: ResolverFn = async (
           meta,
           `*[${deployData.projectName}]* Error deploying \`${deployData.branchName}\`: ${error.message}`
         );
-        return `Error: ${error.message}`;
+        throw new Error(error.message);
     }
   }
 };
@@ -1121,7 +1121,7 @@ export const deployEnvironmentPromote: ResolverFn = async (
           meta,
           `*[${deployData.projectName}]* Error deploying \`${deployData.branchName}\`: ${error.message}`
         );
-        return `Error: ${error.message}`;
+        throw new Error(error.message);
     }
   }
 };