Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align upstream alpine images #1324

Closed
tobybellwood opened this issue Oct 18, 2019 · 7 comments
Closed

Align upstream alpine images #1324

tobybellwood opened this issue Oct 18, 2019 · 7 comments
Labels
9-security Security subsystem

Comments

@tobybellwood
Copy link
Member

Currently, there are different versions of the alpine upstream images in use across the various amazeeio images:

commons uses alpine (3.10 currently)

mariadb uses alpine:3.8

varnish uses alpine:3.7

php uses phpXX-fpm-alpine (3.10 currently)

nginx uses openresty/openresty:alpine (3.9 currently)

node uses node:XX-alpine (3.9 currently)

python uses python:XX-alpine (3.10 currently)

This could lead to potential confusion about what images may be susceptible to vulnerabilities and could benefit from being better aligned.

Where we can control and align the versions, we should - certainly updating the ones we've got set at early versions (unless there's a specific reason?)

@tobybellwood tobybellwood added the 9-security Security subsystem label Oct 18, 2019
@vincenzodnp
Copy link
Contributor

I noticed it today writing documentation.
If not a specific reason why we should alig versions.

@tobybellwood
Copy link
Member Author

In addition - alpine-based solr images are no longer being provided in the solr namespace on dockerhub (as per docker-solr/docker-solr#213)

https://github.com/wodby/base-solr could be an alternative - the decision whether to align base images or base off official (debian-based) images is more important.

@tobybellwood tobybellwood added this to Lagoon 1.4.0 (Feb 2020) in Lagoon Roadmap (Indicative) Jan 30, 2020
@tobybellwood tobybellwood moved this from Lagoon 1.4.0 (Late Feb 2020) to Lagoon 1.3.0 (Mid-Feb 2020) in Lagoon Roadmap (Indicative) Feb 5, 2020
@vincenzodnp
Copy link
Contributor

In addition - alpine-based solr images are no longer being provided in the solr namespace on dockerhub (as per docker-solr/docker-solr#213)

We should use official Solr Slim images

@Schnitzel
Copy link
Contributor

@vincenzodnp
Link to the Solr Slim Images? Reasoning why we should use them?

@tobybellwood
Copy link
Member Author

I've looked into this a bit - as openjdk (which solr is built on) no longer provides official alpine images, we could either build it ourselves (😱) or use the official Debian (Buster) slim images (🤔)

Inheritance:
solr:7.7-slim (https://github.com/docker-solr/docker-solr/blob/master/7.7/slim/Dockerfile)
openjdk:11-jre-slim (https://github.com/docker-library/openjdk/blob/master/11/jre/slim/Dockerfile)
debian:buster-slim (https://github.com/debuerreotype/docker-debian-artifacts/blob/dist-amd64/buster/slim/Dockerfile)

@vincenzodnp
Copy link
Contributor

@Schnitzel @tobybellwood Sorl 7.7.1 is the latest with alpine image (See the PR #1731)
Newer versions are built only on slim version as Toby said above

@Schnitzel Schnitzel moved this from Lagoon 1.3.0 (Mid-End Feb 2020) to Lagoon 1.4.0 (March 2020) in Lagoon Roadmap (Indicative) Mar 27, 2020
@tobybellwood tobybellwood moved this from Lagoon 1.4.0 (April 2020) to Done in Lagoon Roadmap (Indicative) May 25, 2020
@tobybellwood
Copy link
Member Author

closing, as mostly done, and the rest under control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-security Security subsystem
Development

No branches or pull requests

3 participants