Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Solr7.7 and latest Search API Solr module #1731

Merged
merged 5 commits into from
Apr 20, 2020

Conversation

vincenzodnp
Copy link
Contributor

@vincenzodnp vincenzodnp commented Mar 20, 2020

Added support for Solr 7.7 and updated solr-drupal images with the latest configuration files from Drupal Solr Search API module

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Lagoon now support Solr 7.7 and solr-drupal image ships configuration files from latest stable Drupal Solr Search API module

Changelog Entry

  • Added support for Solr 7.7
  • solr-drupal image ships Drupal Solr Search API 8.x-3.9 configuration files

Closing issues

closes #1557

@vincenzodnp
Copy link
Contributor Author

@Schnitzel @dasrecht can you review it?

@Schnitzel
Copy link
Contributor

@vincenzodnp

  • how is this image tested? I don't see a test that would use this?
  • Should we remove solr7.5? Or do we want our customers still allow to use solr7.5 if solr7.7 is out?
  • if we still keep solr7.5 shouldn't we update the drupal config of that one as well?

@vincenzodnp
Copy link
Contributor Author

Hello @Schnitzel

  • how is this image tested? I don't see a test that would use this?

It passed CI checks not tests

  • Should we remove solr7.5? Or do we want our customers still allow to use solr7.5 if solr7.7 is out?

I've discussed with @dasrecht and we stated to keep 7.5 and start to ask customers to switch to 7.7 since 7.5 is EOL.

  • if we still keep solr7.5 shouldn't we update the drupal config of that one as well?

You're right. Going to update it

@Schnitzel
Copy link
Contributor

Schnitzel commented Apr 8, 2020

we stated to keep 7.5 and start to ask customers to switch to 7.7 since 7.5 is EOL.

okay, but removing the docker image here will not remove it from dockerhub, so if we want to tell customers to not use it anymore we should better remove it here, as continue to have it in Lagoon means that we are continue to support it, which it seems to be not the case.

It passed CI checks not tests

Not sure what exactly you mean.
My question was referring to the fact that we are not testing this solr7.7 image anywhere during the automated test system. So I would suggest to use this here:
https://github.com/amazeeio/lagoon/blob/396680e1814aa04060d747defdf37488eb6a1dc2/tests/files/drupal8-dockerfiles/php7.4/solr.dockerfile#L3

Copy link
Contributor

@Schnitzel Schnitzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

@vincenzodnp
Copy link
Contributor Author

@Schnitzel I've removed support for Solr7.5
Updated test to include Solr7.7
Updated documentation for Solr 7.7

@Schnitzel Schnitzel added this to the v1.5.0 milestone Apr 20, 2020
@Schnitzel Schnitzel merged commit 791eb89 into master Apr 20, 2020
@tobybellwood tobybellwood added the 6-images-testing Base Images & Testing subsystem label Apr 30, 2020
@tobybellwood tobybellwood deleted the 1557-update-solr-7.7 branch July 2, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-images-testing Base Images & Testing subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Solr images (inc Solr 7.7 support)
3 participants