Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private container registry incorrectly sets login password #2338

Closed
shreddedbacon opened this issue Nov 20, 2020 · 1 comment
Closed

Private container registry incorrectly sets login password #2338

shreddedbacon opened this issue Nov 20, 2020 · 1 comment

Comments

@shreddedbacon
Copy link
Member

When using the private container registry setup in Lagoon, if you define a password in the lagoon API at the project level, but you have environment level variables defined. The check used will prioritise the environment level variable first, but if there is one not defined, it will set it to an empty value.

https://github.com/amazeeio/lagoon/blob/f2fe153eab7da3c932f8b66b5c7136115a8c1bdc/images/oc-build-deploy-dind/build-deploy-docker-compose.sh#L263-L268

The logic needs to be updated to check if the value is not empty before setting it.

@rocketeerbkw
Copy link
Member

Fixed in 2.x with #2387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants