Check for the existence of private container registry password better #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore overwriting the one from project. also error if no password can actually be found
shreddedbacon
force-pushed
the
privateregistrycheck
branch
from
9440092
to
7c43aa1
Compare
shreddedbacon
force-pushed
the
privateregistrycheck
branch
from
7c43aa1
to
1f7cdd5
Compare
cdchris12
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
In certain conditions, if an environment has a private container registry configured with credentials in the API at the project level, if any environment level variables are added then the private container registry credential would get set to an empty value and fail.
This checks that the credential is not empty before setting it, and also informs the user if no credential can be found.
Closing issues
closes #2338