Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API updates not happening when environments with special characters complete. #2568

Closed
shreddedbacon opened this issue Mar 12, 2021 · 2 comments
Assignees
Labels
2-build-deploy Build & Deploy subsystem

Comments

@shreddedbacon
Copy link
Member

Describe the bug

There is currently an issue where if an environment that has special characters in it, eg /, are handled by the controller.

Currently Lagoon will make safe (dns compliant) environment names before sending to the controller. This is fine, but any time an update or entry is returned to Lagoon to be handled by the controllerhandler, the API check for the environment fails as lagoon is expecting to see the environment name before it was made safe.

To Reproduce

Steps to reproduce the behavior:

  1. Deploy an environment like feature/my-cool-feature
  2. On completion check the API/UI for the existence of any ROUTES
  3. See there are no routes

Expected behavior

Routes and/or other updates should be in the API

Additional context

Checking the controllerhandler logs shows that the updates failed because of the environment not being found, further investigation shows that this is because of the environment name being made dns-compliant before being sent to the controller.

@shreddedbacon
Copy link
Member Author

Just adding this to make sure the issue was known and that #2565 is raised is to fix this issue specifically

It does NOT attempt to solve #2322

@rocketeerbkw
Copy link
Member

Fixed in 2.x with #2596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-build-deploy Build & Deploy subsystem
Projects
None yet
Development

No branches or pull requests

2 participants